feat: Multi factor Authentication #1273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellwheatley
changed the title
russellwheatley
force-pushed
the
mfa-enrollment
branch
from
f3d28b3 to
b8a0a4d
Compare
russellwheatley
force-pushed
the
mfa-enrollment
branch
from
b8a0a4d to
571f479
Compare
demolaf
reviewed
Oct 8, 2025
| } | ||
|
|
||
| func reauthenticateCurrentUser(on user: User) async throws { | ||
| if let providerId = signedInCredential?.provider { |
There was a problem hiding this comment.
we can use a guard here instead and throw AuthServiceError.reauthenticationRequired("Recent login required to perform this operation.")
demolaf
reviewed
Oct 8, 2025
| .font(.headline) | ||
| .padding(.horizontal) | ||
|
|
||
| ForEach(enrolledFactors, id: \.uid) { factor in |
There was a problem hiding this comment.
can MultiFactorInfo conform to Identifiable, where id is a computed property from uid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full flow for MFA.