Logs the presence of Firebase Auth UI in Auth server requests. #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
approved these changes
Sep 22, 2017
| /** @category FIRAuth(InternalInterface) | ||
| @brief Redeclares the internal interface not publicly exposed in FIRAuth. | ||
| */ | ||
| @interface FIRAuth (InternalInterface) |
There was a problem hiding this comment.
Why not put this in the @interface FUIAuth () declaration down below?
edit: ah, I see they're different classes
yramanchuk
approved these changes
Sep 22, 2017
FirebaseAuthUI/FUIAuth.m
Outdated
| authUI = [[FUIAuth alloc] initWithAuth:auth]; | ||
| objc_setAssociatedObject(auth, &kAuthAssociationKey, authUI, | ||
| OBJC_ASSOCIATION_RETAIN_NONATOMIC); | ||
| auth.additionalFrameworkMarker = kFirebaseAuthUIFrameworkMarker; |
There was a problem hiding this comment.
Xiangtian, if we are calling private API we should make sure that method exists. Just in case method signature may be changed in the future, FirebaseUI should be notified that it stopped logging.
Also can we label this as a temp approach? I think, if we can anyway set this value, it doesn't matter, if we are calling private or public method. So it's better to have public method later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.