Add one-time code text content type to phone auth #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ic9f9a86ac38331a5b8cbce7a7eb79a0217235e50
morganchen12
force-pushed
the
autofill
branch
from
1c6edbf to
f8cf092
Compare
Yue-Wang-Google
approved these changes
Sep 5, 2018
| return textFieldSize; | ||
| } | ||
|
|
||
| - (UITextContentType)textContentType { |
There was a problem hiding this comment.
Nullability specifier 'nonnull' conflicts with existing specifier '_Null_unspecified'
There was a problem hiding this comment.
I'm seeing this issue as well. 5.2.1 fails to build for me with this error.
There was a problem hiding this comment.
The fix has been released in 5.2.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #515.
May break builds on non-beta versions of Xcode.