This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Update methods to Firebase 2.0.x #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/FirebaseArray.js
Outdated
There was a problem hiding this comment.
Comment this and explain why it exists? (that we we won't wonder what it was here for in a year) Might also want to //todo it so we can remove it later.
|
Looks good @jwngr; two comments for you to consider. |
|
@katowulf - Back to you. Thanks for the comments! |
katowulf
added a commit
that referenced
this pull request
Nov 6, 2014
Update methods to Firebase 2.0.x
|
Thanks for the amazing work on these updates, @jwngr! Great stuff. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@katowulf - This is a backwards-compatible solution to upgrade AngularFire to 2.0.x without having it throw any deprecation warnings. Unfortunately, we cannot polyfill
DataSnapshot.key()since we do not publicly exposeDataSnapshot, onlyFirebase. As a result, I had to add these helper methods to usekey()if it exists, or otherwise usename(). We need to make sure that in the future, we are aware that we cannot do things likesnapshot.key()orsnapshot.name()and instead need to usethis._getSnapshotKey(snapshot).The good news is that this is literally all we need to do to achieve backwards compatibility. We don't use the deprecated
limit()method internally and all other methods are already backwards compatible.cc/ @davideast