Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Conversation

kmturley
Copy link

Description

Fixing the jspm install issue:
#857

Code sample

I added the package.json version (which jspm requires for installation)

"version": "2.3.0",

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kmturley
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.716% when pulling 2514e36 on kmturley:master into e1dff6f on firebase:master.

@jwngr
Copy link

jwngr commented Feb 21, 2017

Weird... We actually intentionally set the version number to 0.0.0 and do a string replace on that value when we cut new releases. So I'd prefer not to change it if we can avoid that. Do you know why jspm pulls from the master branch of the GitHub repo instead of from our tagged release commits like Bower?

@kmturley
Copy link
Author

Other registries like npm surely use the package.json version aswell? Maybe you can commit the updates?

I believe the default behaviour is that it will look at the master branch. However users can override it by using the semvar versioing format:
https://github.com/jspm/jspm-cli/blob/master/docs/installing-packages.md

jspm install angularfire@^2.3.0

You can also submit an override to the jspm registry repo, which would set the default for every user:
https://github.com/jspm/registry#submitting-a-package-override

@jwngr
Copy link

jwngr commented Feb 21, 2017

We do commit the updated version number, but only for the commits which we tag as releases (e.g. 8678f72). I think I found a way to make it so that we don't need to use the 0.0.0 placeholder anymore in our release process though. Give me a little bit of time to fix that up and then we can get the version actual numbers back in the package.json.

@kmturley
Copy link
Author

Cool, I've not done that with grunt before but it seems npm version is one of the best ways to do it.
https://docs.npmjs.com/cli/version

There is a grunt bump plugin which can do it too

@kmturley kmturley closed this Feb 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants