docs(firestore-bigquery-export): update import script instructions for npm info #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add info that you install the script via npm - add info about needing Node.js - add intro line about which extension the script is for - general style updates
rachelsaunders
requested review from
fredzqm,
jmwski,
jhuleatt and
laurenzlong
|
please DO NOT MERGE until JHULEATT has reviewed this PR. |
fredzqm
approved these changes
Oct 28, 2019
jmwski
approved these changes
Oct 29, 2019
laurenzlong
suggested changes
Nov 4, 2019
jhuleatt
reviewed
Nov 12, 2019
|
@rachelsaunders do you also want to use this PR to move the contents of this file into a new README.md so that the contents get displayed on npm? Or would it be easier to save that for another PR? |
Addresses jhuleatt@'s comment: Now that we're using npx, this should say "Run the import script" instead of "Install the import script"
|
@jhuleatt I'd like to do the file move in a separate PR. I _think that if we do the move in this PR, then the PR will just show the whole file as changed, rather than just the individual diffs. Is this ok? |
jhuleatt
approved these changes
Nov 13, 2019
|
Waiting for another PR makes sense. LGTM! |
Salakar
changed the title
Salakar
changed the title
laurenzlong
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to IMPORT_EXISTING_DOCUMENTS.md include:
Note that this file is only visible in GitHub so its content does not display in the Firebase Console or CLI. The PRE and POST install files do make reference to this file's existence, but nothing in this PR changes the content of those files.