Improved error handling in iid package #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bklimt
reviewed
May 29, 2018
|
|
||
| if msg, ok := errorCodes[resp.Status]; ok { | ||
| return fmt.Errorf("instance id %q: %s", iid, msg) | ||
| if info, ok := errorCodes[resp.Status]; ok { |
There was a problem hiding this comment.
I notice we're only using the http status code here. Can't our APIs return more specific error codes in the body of the response? Or am I thinking of something else?
There was a problem hiding this comment.
The endpoint we use for this functionality today signals errors via HTTP status code. In the future the backend service will send more detailed and well-formed error responses.
bklimt
approved these changes
May 29, 2018
hiranya911
added a commit
that referenced
this pull request
Jun 12, 2018
* Improved error handling in iid package * Updated changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #149
go/firebase-go-iid-errors