Refactoring the user management integration tests #152
Conversation
| } | ||
|
|
||
| func deleteUser(uid string) { | ||
| client.DeleteUser(context.Background(), uid) |
There was a problem hiding this comment.
I feel like we should at least check the error state and print out a warning or something.
I'm not sure if it would make sense, but we could maybe pass a *testing.T into this function and fail the test if the delete fails.
There was a problem hiding this comment.
This is intended to be a best effort delete operation. I don't think we want to fail a test because the clean up operation failed. Added a comment stating this.
There was a problem hiding this comment.
I still think it would be good to print out a warning when it fails.
| func randomString(length int) string { | ||
| b := make([]byte, length) | ||
| func randomUID() string { | ||
| var letters = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789") |
There was a problem hiding this comment.
Arrays cannot be const in Go.
integration/auth/user_mgt_test.go
Outdated
| } | ||
|
|
||
| func randomPhoneNumber() string { | ||
| var letters = []rune("0123456789") |
There was a problem hiding this comment.
I would maybe name this digits.
integration/auth/auth_test.go
Outdated
| } | ||
|
|
||
| func TestCustomTokenWithClaims(t *testing.T) { | ||
| ct, err := client.CustomTokenWithClaims(context.Background(), "user2", map[string]interface{}{ |
There was a problem hiding this comment.
Do you want to use random UIDs on all these other tests?
* Adding new user mgt integ tests * Reimplemented user mgt integ tests * Fixed update test * Minor updates for clarity
The existing test suite is essentially one big test case composed of many helper functions. It also keeps a lot of intermediate state (fixtures), and tends to leave the Firebase project in an inconsistent state on failures. This PR:
deferkeyword to ensure graceful tear downResolves #145