Skip to content

Implemented SendMulticast() API and dryRun support #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 31, 2019
Merged

Implemented SendMulticast() API and dryRun support #258

merged 7 commits into from
Jul 31, 2019

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Jul 19, 2019 •
edited
Loading

Continuation of #257. Adding the rest of the multicast/batch APIs.

SendAllDryRun(ctx context.Context, messages []*Message) (*BatchResponse, error)
SendMulticast(ctx context.Context, m *MulticastMessage) (*BatchResponse, error)
SendMulticastDryRun(ctx context.Context, m *MulticastMessage) (*BatchResponse, error)

go/fcm-multicast

Resolves #213

@hiranya911 hiranya911 requested a review from bklimt July 19, 2019 20:23
@chemidy
Copy link
Contributor

chemidy commented Jul 27, 2019

Missing snippets for the doc

bklimt
bklimt approved these changes Jul 31, 2019
View reviewed changes
@bklimt bklimt assigned hiranya911 and unassigned bklimt Jul 31, 2019
@hiranya911 hiranya911 merged commit 512351f into dev Jul 31, 2019
@hiranya911 hiranya911 deleted the hkj-multicast-message branch July 31, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bklimt bklimt bklimt approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiranya911 @chemidy @bklimt