Skip to content

Adding golang 1.12 to the CI matrix #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2019
Merged

Adding golang 1.12 to the CI matrix #262

merged 2 commits into from
Jul 26, 2019

Conversation

chemidy
Copy link
Contributor

@chemidy chemidy commented Jul 26, 2019

  • Adding golang 1.12 to the CI matrix, golang 1.13 is coming

@hiranya911 hiranya911 changed the base branch from master to dev July 26, 2019 16:46
hiranya911
hiranya911 approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 merged commit ab1fb5c into firebase:dev Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chemidy @hiranya911