Added Create and Update APIs for SAML configs #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auth/provider_config.go
Outdated
| // SSOURL sets the SSOURL field of the new config. | ||
| func (config *SAMLProviderConfigToCreate) SSOURL(url string) *SAMLProviderConfigToCreate { | ||
| config.set(ssoURLKey, url) | ||
| return config |
There was a problem hiding this comment.
Very minor thing... some places in the code we set the values first and then return the config object and in other places we do a single line return return config.set(ssoURLKey, url). It might be better to keep it consistent everywhere
There was a problem hiding this comment.
Good catch. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
CreateSAMLProviderConfig()andUpdateSAMLProviderConfig()functions.Also introducing a
nestedMaphelper type that makes it easier to model the create/update parameters as a nested map and build update masks.