Skip to content

Added OIDCProviderConfig API #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2019
Merged

Added OIDCProviderConfig API #282

merged 2 commits into from
Oct 17, 2019

Conversation

hiranya911
Copy link
Contributor

Added OIDCProviderConfig() and DeleteOIDCProviderConfig() functions.

lahirumaramba
lahirumaramba approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

auth/provider_config_test.go
)

const oidcConfigResponse = `{
"name":"projects/mock-project-id/oauthIdpConfigs/oidc.provider",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name":"projects/mock-project-id/oauthIdpConfigs/oidc.provider",
"name": "projects/mock-project-id/oauthIdpConfigs/oidc.provider",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hiranya911 hiranya911 merged commit 1d6682d into dev Oct 17, 2019
@hiranya911 hiranya911 deleted the hkj-oidc-config branch October 17, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiranya911 @lahirumaramba