Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Date test in another Locale #327

Merged
merged 3 commits into from Nov 6, 2019

Conversation

@sakebook
Copy link
Contributor

sakebook commented Nov 6, 2019

Discussion

No issue.

Current Date test is depend on Locale(GMT).

I ran the test on my local machine and it was not successful.
This is because the Japanese locale (JMT) is used.

I defined use Locale.US.

Testing

Fixed test

API Changes

None

RELEASE NOTE: Fixed a bug in date string parsing during error handling.

Copy link
Member

hiranya911 left a comment

Thanks @sakebook. Just one change needed, and then we can merge.

new SimpleDateFormat(PATTERN_RFC1123),
new SimpleDateFormat(PATTERN_RFC1036),
new SimpleDateFormat(PATTERN_ASCTIME)
new SimpleDateFormat(PATTERN_RFC1123, Locale.UK),

This comment has been minimized.

Copy link
@sakebook

sakebook Nov 6, 2019

Author Contributor

I fixed it. 3e8ec14

Copy link
Member

hiranya911 left a comment

LGTM 👍

@hiranya911 hiranya911 assigned hiranya911 and unassigned sakebook Nov 6, 2019
@hiranya911 hiranya911 merged commit 76f0f95 into firebase:master Nov 6, 2019
3 checks passed
3 checks passed
Trigger: 3413a0d4-6450-4b83-aeb3-ee8e3eeb9d70 Summary
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hiranya911 hiranya911 changed the title Fix Date test in another Locale fix: Date test in another Locale Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.