Skip to content

fix: Importing GCP dependencies via official BOMs #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2020
Merged

fix: Importing GCP dependencies via official BOMs #451

merged 2 commits into from
Jul 10, 2020

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Jul 9, 2020 •
edited
Loading

  • Importing guava, google-cloud-* and google-http-client via libraries-bom.
  • Import google-api-client via google-api-client-bom

Resolves #450

RELEASE NOTE: Admin SDK now imports all Google Cloud Platform dependencies via com.google.cloud:libraries-bom.

@hiranya911 hiranya911 mentioned this pull request Jul 9, 2020
Closed
schmidt-sebastian
schmidt-sebastian reviewed Jul 9, 2020
View reviewed changes
BenWhitehead
BenWhitehead approved these changes Jul 10, 2020
View reviewed changes
Copy link

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 merged commit eeee30b into master Jul 10, 2020
@hiranya911 hiranya911 deleted the hkj-lib-bom branch July 10, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hiranya911 hiranya911

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leverage libraries-bom to ensure compatible transitive dependencies between google-cloud-storage & google-cloud-firestore
3 participants
@hiranya911 @BenWhitehead @schmidt-sebastian