-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make writeTimeout configurable (similar to readTimeout) #900
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG with a nit, thanks!
@@ -207,6 +210,16 @@ public int getReadTimeout() { | |||
return readTimeout; | |||
} | |||
|
|||
/** | |||
* Returns the write timeout in milliseconds, which is applied to outgoing REST calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a case for "that" instead of which, let's just rephrase to something like:
"Returns the write timeout applied to outgoing REST calls in milliseconds."
If you think we can go ahead and assume "by the SDK."
Address TW reviews in #900
Solves #850