Skip to content

Conversation

avishalom
Copy link
Contributor

Adding comments regarding test coverage to the CONTRIBUTING file.

@avishalom avishalom requested a review from hiranya911 January 9, 2018 16:30
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

and point your browser to
`file:///<dir>/htmlcov/index.html` (where `dir` is the location from which the report was created).


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Remove extra space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add to next PR

@avishalom avishalom merged commit f6a6610 into master Jan 11, 2018
@avishalom avishalom deleted the contributing branch February 13, 2018 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants