Create CHANGELOG.md #119
Merged
Create CHANGELOG.md #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create changlelog from https://firebase.google.com/support/release-notes/admin/python
hiranya911
approved these changes
Jan 19, 2018
There was a problem hiding this comment.
LGTM with one follow up question.
@avishalom can you also take a look?
CHANGELOG.md
Outdated
|
|
||
| ### Initialization | ||
|
|
||
| - [added] The [`initialize_app()`](/docs/reference/admin/node/admin#.initializeApp) |
There was a problem hiding this comment.
We use relative URLs (starting with /docs/) in the Firebase devsite, but that won't work in Github. Should we fix that?
There was a problem hiding this comment.
Oh yeah, I thought I had fixed those everywhere by putting in the full path.. I did search and replace so not sure how I missed this one or others, so let me double check and address
Oops.. forgot to fully qualify docs urls
avishalom
approved these changes
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create changlelog from https://firebase.google.com/support/release-notes/admin/python