Skip to content

Conversation

hiranya911
Copy link
Contributor

The error codes defined in https://firebase.google.com/docs/reference/fcm/rest/v1/ErrorCode are embedded in the details section of the error response. The top-level error code (status field in the response) may take additional values such as NOT_FOUND and UNAUTHENTICATED (the so called canonical error codes):

{
  "error":{
    "code":404,
    "message":"Requested entity was not found.",
    "status":"NOT_FOUND",
    "details: [
      {
         "@type":"type.googleapis.com/google.firebase.fcm.v1.FcmError",
         "errorCode":"UNREGISTERED"
      }
    ]
  }
}

This PR updates the FCM implementation to handle these additional error codes and map them to correct client-side errors.

@avishalom avishalom assigned hiranya911 and unassigned avishalom Mar 1, 2018
@hiranya911 hiranya911 merged commit bf783c3 into master Mar 1, 2018
@hiranya911 hiranya911 deleted the hkj-fcm-errors branch March 1, 2018 01:49
@dhruv-aggarwal
Copy link

@hiranya911 when are you planning on releasing this change?
Need this for proper handling of token refresh.

@dhruv-aggarwal
Copy link

@hiranya911 @avishalom can you please tell when are you planning on releasing this?

carsongee pushed a commit to carsongee/firebase-admin-python that referenced this pull request Mar 13, 2018
@hiranya911
Copy link
Contributor Author

@dhruv-aggarwal We'll try to get a release out this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants