Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for timeouts in messaging module #132

Merged
merged 1 commit into from Mar 9, 2018

Conversation

@carsongee
Copy link
Contributor

@carsongee carsongee commented Mar 8, 2018

This adds support for using the httpTimeout option from the App for specifying client timeout parameters inside of the messaging module.

@googlebot
Copy link

@googlebot googlebot commented Mar 8, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

Loading

@carsongee
Copy link
Contributor Author

@carsongee carsongee commented Mar 8, 2018

I signed it!

Loading

@googlebot
Copy link

@googlebot googlebot commented Mar 8, 2018

CLAs look good, thanks!

Loading

@carsongee carsongee force-pushed the feature/messaging_timeout branch from 861b9ca to d66b274 Mar 8, 2018
Copy link
Member

@hiranya911 hiranya911 left a comment

Thanks @carsongee. This looks great. Can you also add a test case? Something similar to: https://github.com/firebase/firebase-admin-python/blob/master/tests/test_db.py#L597

Loading

@hiranya911 hiranya911 self-assigned this Mar 8, 2018
@carsongee
Copy link
Contributor Author

@carsongee carsongee commented Mar 8, 2018

I'll try and get that test written tomorrow, thanks for the consideration

Loading

@carsongee carsongee force-pushed the feature/messaging_timeout branch 4 times, most recently from 0f6cf00 to f0247c4 Mar 9, 2018
@carsongee
Copy link
Contributor Author

@carsongee carsongee commented Mar 9, 2018

tests added

Loading

Copy link
Member

@hiranya911 hiranya911 left a comment

Please fix the lint error, and then this is good to go.

Loading

@@ -817,6 +855,7 @@ def test_send(self):
assert len(recorder) == 1
assert recorder[0].method == 'POST'
assert recorder[0].url == self._get_url('explicit-project-id')
assert recorder[0]._extra_kwargs['timeout'] == None
Copy link
Member

@hiranya911 hiranya911 Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement this check with is None to avoid the lint error: https://travis-ci.org/firebase/firebase-admin-python/jobs/351093644#L552

Loading

@carsongee carsongee force-pushed the feature/messaging_timeout branch from f0247c4 to a90f4c8 Mar 9, 2018
@hiranya911 hiranya911 merged commit 328036c into firebase:master Mar 9, 2018
2 checks passed
Loading
carsongee added a commit to carsongee/firebase-admin-python that referenced this issue Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants