Moved package information to __about__.py to avoid dependency issues #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks solid. Thanks @carsongee for the PR. |
|
@avishalom please check if we can include this in the next release. |
avishalom
reviewed
Mar 14, 2018
scripts/prepare_release.sh
Outdated
| if [ -z "$CUR_VERSION" ]; then | ||
| echo "[ERROR] Failed to find the current version. Check firebase_admin/__init__.py for version declaration." | ||
| echo "[ERROR] Failed to find the current version. Check firebase_admin/__version__.py for version declaration." |
There was a problem hiding this comment.
s/__version__.py/__about__.py/ ?
carsongee
force-pushed
the
feature/setup_deps
branch
from
d8b5c6c to
36edf7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #133 warehouse style.
Happy to add more or remove more from
__about__.py, just picked out what seemed like the obvious ones.