Skip to content

Conversation

jwngr
Copy link

@jwngr jwngr commented Apr 6, 2017

Description

NOTE: this PR is against an io-2017 branch, not master.

Updating the license to Apache 2.0, which we will use when open sourcing this library at I/O 2017. Since there is no build step, I'm not sure if there's a better way to do this other than to manually copy these headers over the relevant files. Let me know if you have ideas though.

Code sample

N/A

@jwngr jwngr requested a review from hiranya911 April 6, 2017 00:03
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor suggestion. Everything else is great. LGTM.


"""Setup file for distribution artifacts."""
from __future__ import print_function

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also add the classifier "License :: OSI Approved :: Apache Software License" to the list of classifiers in this file.

From https://pypi.python.org/pypi?%3Aaction=list_classifiers

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hiranya911 hiranya911 assigned jwngr and unassigned hiranya911 Apr 10, 2017
@jwngr jwngr assigned hiranya911 and unassigned jwngr Apr 10, 2017
@hiranya911
Copy link
Contributor

LGTM

@hiranya911 hiranya911 assigned jwngr and unassigned hiranya911 Apr 11, 2017
@jwngr jwngr merged commit b3ae52b into io-2017 Apr 11, 2017
@jwngr jwngr deleted the jw-license branch April 11, 2017 22:31
@jwngr jwngr removed their assignment Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants