Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and refactored the db.Reference.listen() API #190

Merged
merged 6 commits into from
Aug 13, 2018
Merged

Conversation

hiranya911
Copy link
Contributor

Continuation of #183

  • KeepAuthSession now extends from the AuthorizedSession. This allows the listen() API to properly authorize outgoing requests.
  • Added db.Event type. The callback gets fired with instances of this class.
  • Updated documentation and changelog.
  • Cleaned up the code and added more unit tests.

@hiranya911
Copy link
Contributor Author

@the-c0d3r please take a look.

@the-c0d3r
Copy link
Contributor

@hiranya911 I have looked at the changes. It looks good, much cleaner than what I wrote. But the problem you mentioned in #183 I do not see the problem. But I have been using the SDK with the authentication json file. So that may be obscuring the problem.

@hiranya911
Copy link
Contributor Author

@the-c0d3r You probably have your database security rules set to public, allowing unauthenticated access to the data. I encountered the issue when testing with a service account json file.

@hiranya911 hiranya911 assigned hiranya911 and unassigned bjornick Aug 11, 2018
@hiranya911 hiranya911 merged commit 62fb76d into master Aug 13, 2018
@hiranya911 hiranya911 deleted the hkj-db-listen branch August 13, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants