Scoping credentials to Firebase services #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
approved these changes
May 9, 2017
tests/test_credentials.py
Outdated
| @@ -27,6 +27,13 @@ | |||
| from tests import testutils | |||
|
|
|||
|
|
|||
| def check_scopes(g_credential): | |||
| assert isinstance(g_credential, google.auth.credentials.Scoped) | |||
| assert len(credentials._scopes) == len(g_credential.scopes) | |||
There was a problem hiding this comment.
If this assertion fails you'll have a hard time figuring out what went wrong.
Better assert the lists are equal, e.g. via self.assertEqual(sorted(credentials._scopes), sorted(g_credential.scopes)).
There was a problem hiding this comment.
Updated the test as proposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.