Skip to content

Implementing the API changes proposed in the final review #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2017
Merged

Implementing the API changes proposed in the final review #35

merged 1 commit into from
Jun 20, 2017

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Jun 20, 2017 •
edited
Loading

  • Removing priority operations from the API (we can add these later if there's a demand for it).
  • App.get_token() method has been renamed and removed from the public API.
  • Numerous method renames.
  • dbURL option renamed to databaseURL.
  • Updated affected test cases.

Related to #28

@hiranya911
Implementing the API changes proposed in the final review: Removing a…
a747be0 
…ll support for piorities, Removing App.get_token() from the public API
@hiranya911 hiranya911 requested a review from bjornick June 20, 2017 18:57
@hiranya911 hiranya911 assigned hiranya911 and unassigned bjornick Jun 20, 2017
@hiranya911 hiranya911 merged commit 0bf122e into master Jun 20, 2017
@hiranya911 hiranya911 deleted the hkj-api-cleanup branch June 20, 2017 20:29
@hiranya911 hiranya911 mentioned this pull request Jun 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornick bjornick bjornick approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiranya911 @bjornick