Skip to content

Speeding up the HTTPClient tests by reusing the test server instance #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

Speeding up the HTTPClient tests by reusing the test server instance #387

merged 1 commit into from
Jan 15, 2020

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Jan 15, 2020 •
edited
Loading

Repeatedly starting pytest_localserver is an expensive operation. This fix uses the same instance for multiple test cases in the same class.

Before fix:

2370 passed in 18.37s

After fix:

2370 passed in 10.60s

lahirumaramba
lahirumaramba approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this optimization!

@hiranya911 hiranya911 merged commit 0e4f3bf into master Jan 15, 2020
@hiranya911 hiranya911 deleted the hkj-fast-http branch January 15, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiranya911 @lahirumaramba