Fixing Some Nits in Tests #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
reviewed
Jun 26, 2017
| @@ -81,7 +81,7 @@ class TestApplicationDefault(object): | |||
|
|
|||
| @pytest.mark.parametrize('app_default', [testutils.resource_filename('service_account.json')], | |||
| indirect=True) | |||
| def test_init(self, app_default): # pylint: disable=unused-argument | |||
| def test_init(self, app_default): | |||
There was a problem hiding this comment.
You can suppress these warnings without needing to disable this check for all methods in tests:
For example, here you can
def test_init(self, app_default):
del app_defaultIf that's just too annoying, carry on.
…-python into hkj-test-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integration/directory to linterunused-argumentcheck for tests. This condition occurs far too often in tests (when setting up pytest fixtures)