chore: Making the separation between staging and publishing explicit #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently staging and publishing happen in a single job. We simply regulate when publishing steps are invoked by examining the PR metadata. This change makes this distinction more explicit by refactoring the publish steps into a separate job.
The publish job is invoked only when:
needs: stage_release), andif: ....).The
stage_releasejob tests, builds and uploads the release artifacts. Thepublish_releasejob downloads the same artifacts, and posts them to Pypi (not implemented yet).I'm also disabling the egg file binary distribution and instead configuring wheel and source distributions. This is consistent with how other GCP Python packages are published (e.g. https://pypi.org/project/google-auth/#files).
Sample run: https://github.com/firebase/firebase-admin-python/actions/runs/36064065