chore: Cleaning up scripts used in the old release process #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
approved these changes
Feb 25, 2020
| @@ -1,6 +1,6 @@ | |||
| name: Continuous Integration | |||
|
|
|||
| on: push | |||
| on: pull_request | |||
There was a problem hiding this comment.
Do we need both push and pull_request events to trigger CI if we make changes to a PR based on reviews?
There was a problem hiding this comment.
pull_request events are triggered on open, synchronize and reopen sub events. synchronize sub event covers the case we need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull_requestevents instead ofpush. This is required to ensure that we run CI on pull requests sent by external contributors. This does mean we no longer run CI on every push, which should be fine given that we review all changes through a PR.