Implemented a util for getting project ID from the credential or the environment #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornick
requested changes
Sep 6, 2017
firebase_admin/_utils.py
Outdated
| Returns: | ||
| str: A project ID value or None. | ||
| """ | ||
| pid = app.options.get('projectId') |
There was a problem hiding this comment.
Wouldn't it make sense to initialize app to get all the values from the environment as opposed doing this lookup every time someone calls project_id(app)?
There was a problem hiding this comment.
Done. Now this logic runs as part of firebase_admin.initialize_app(). Updated test cases accordingly.
|
Made the suggested change. Project ID look up logic is now moved to |
bjornick
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utilsmethod as_utilsproject_id()function