fix: Correctly catch DefaultCredentialsError when looking up project_id #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanedey
changed the title
lahirumaramba
approved these changes
Sep 20, 2023
| @@ -257,7 +258,7 @@ def _lookup_project_id(self): | |||
| if not project_id: | |||
| try: | |||
| project_id = self._credential.project_id | |||
| except AttributeError: | |||
| except (AttributeError, DefaultCredentialsError): | |||
| pass | |||
There was a problem hiding this comment.
Do we want to throw here or pass?
There was a problem hiding this comment.
We want to pass and look for other ways of getting a project_id.
|
Noticed that I am not explicitly triggering the exceptions in the unit tests. Doing that caught that I also needed to clear gcloud env to ensure the exception is thrown. |
lahirumaramba
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultCredentialsErrorwas not being caught when trying to loadproject_idfrom credentials.Added a catch for this error along with unit tests.
Related: #609