Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add PyJWKClientError to raised errors documentation and handle possible uncaught errors. #733

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix: Add PyJWKClientError to raised errors documentation and handle possible uncaught errors. #733

merged 2 commits into from
Nov 15, 2023

Conversation

jonathanedey
Copy link
Contributor

Related to #704

@jonathanedey jonathanedey linked an issue Oct 24, 2023 that may be closed by this pull request
app_check.verify_token can also raise PyJWKClientError, but that is not documented #704
Closed
@jonathanedey jonathanedey self-assigned this Oct 24, 2023
@jonathanedey jonathanedey marked this pull request as ready for review October 24, 2023 13:31
egilmorez
egilmorez approved these changes Oct 24, 2023
View reviewed changes
Copy link

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With one small nit, good from a verbiage perspective, thanks!

firebase_admin/app_check.py Outdated Show resolved Hide resolved
@jonathanedey jonathanedey requested review from lahirumaramba and removed request for hsubox76 November 14, 2023 22:02
lahirumaramba
lahirumaramba approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jonathanedey jonathanedey merged commit c77608e into master Nov 15, 2023
11 checks passed
@jonathanedey jonathanedey deleted the je-pyjwk-error branch November 15, 2023 20:20
jonathanedey added a commit that referenced this pull request Nov 16, 2023
@jonathanedey
fix: Add PyJWKClientError to raised errors documentation and handle…
e90e2ad 
… possible uncaught errors. (#733)

* fix: Add PyJWKClientError to raised error documentaion and handle possible uncaught errors

* fix: grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@egilmorez egilmorez egilmorez approved these changes

Assignees

@jonathanedey jonathanedey

Labels
api: appcheck release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app_check.verify_token can also raise PyJWKClientError, but that is not documented
3 participants
@jonathanedey @lahirumaramba @egilmorez