Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fcm): Enabled the direct_boot_ok parameter for FCM Android Config. #734

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Oct 24, 2023

Enable direct_boot_ok in FCM Android Config.
If set to true, messages will be allowed to be delivered to the app while the device is in direct boot mode.
This allows developers to the parameter through the Admin SDK, a functionality which already exists and works in HTTP v1.

@jonathanedey jonathanedey changed the title feat(fcm): Enabled the direct_boot_ok Android Config parameter. feat(fcm): Enabled the direct_boot_ok parameter for FCM Android Config. Oct 25, 2023
@jonathanedey jonathanedey marked this pull request as ready for review November 15, 2023 17:04
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments LGTM, thanks!

@jonathanedey jonathanedey merged commit 4f20371 into master Jan 9, 2024
11 checks passed
@jonathanedey jonathanedey deleted the je-direct-boot branch January 9, 2024 15:56
jonathanedey added a commit that referenced this pull request Feb 13, 2024
…fig. (#734)

* feat(fcm): Enabled direct_boot_ok Android Config parameter.

* Added tests.

* fix: add to correct config.

* fix: Validator label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants