Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Firebase test project setup instructions. #736

Merged
merged 6 commits into from
Dec 19, 2023

Conversation

jonathanedey
Copy link
Contributor

Updated the test project setup instructions to be more accurate to the current setup flow.

@jonathanedey jonathanedey changed the title Update Firebase test project setup instructions. chore: Update Firebase test project setup instructions. Nov 13, 2023
@jonathanedey jonathanedey marked this pull request as ready for review November 16, 2023 16:20
Copy link

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jonathanedey jonathanedey merged commit 7a9dfa0 into master Dec 19, 2023
11 checks passed
@jonathanedey jonathanedey deleted the je-project-setup branch December 19, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants