Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump github actions CI to use Node 20 #748

Merged
merged 2 commits into from
Dec 19, 2023
Merged

chore: Bump github actions CI to use Node 20 #748

merged 2 commits into from
Dec 19, 2023

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Dec 19, 2023 •
edited

  • firebase-tools v13 drops support for node 16 which breaks Continuous Integration.
  • Updating CI to use Node 20:
    • actions/checkout: v4
    • actions/setup-node: v4

@jonathanedey jonathanedey changed the title Lock firebase-tools to v13 and bump actions to use Node 20. chore: Lock firebase-tools to v13 and bump actions to use Node 20. Dec 19, 2023
@jonathanedey jonathanedey changed the title chore: Lock firebase-tools to v13 and bump actions to use Node 20. chore: Lock firebase-tools to v13 and bump actions CI to use Node 20. Dec 19, 2023
lahirumaramba
lahirumaramba approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@jonathanedey jonathanedey changed the title chore: Lock firebase-tools to v13 and bump actions CI to use Node 20. chore: Bump github actions CI to use Node 20 Dec 19, 2023
@jonathanedey jonathanedey marked this pull request as ready for review December 19, 2023 17:14
@jonathanedey jonathanedey merged commit e073f8c into master Dec 19, 2023
11 checks passed
@jonathanedey jonathanedey deleted the je-bump-actions branch December 19, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathanedey @lahirumaramba