Skip to content

Fixing a failing test #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2017
Merged

Fixing a failing test #75

merged 1 commit into from
Sep 21, 2017

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Sep 21, 2017 •
edited
Loading

(failure caused by a change made in google-auth v1.1.1 that went out today)

Low-level details:

  • Scoped extends ReadOnlyScoped
  • Starting from v1.1.1 some oauth2 credential types extend from ReadOnlyScoped instead of Scoped.

@hiranya911 hiranya911 requested a review from bjornick September 21, 2017 17:37
@hiranya911 hiranya911 assigned hiranya911 and unassigned bjornick Sep 21, 2017
@hiranya911 hiranya911 merged commit 79eb995 into master Sep 21, 2017
@hiranya911 hiranya911 deleted the hkj-test-fix branch September 21, 2017 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornick bjornick bjornick approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiranya911 @bjornick