Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Release 6.4.0 Take 3 #763

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[chore] Release 6.4.0 Take 3 #763

merged 1 commit into from
Jan 23, 2024

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Jan 23, 2024 •
edited
Loading

Issue

  • Setting Github actions permissions using the permissions syntax sets all unlisted permissions to none.
  • By adding the id-token permission needed for PyPi Trusted Publishers authentication, all other permissions at the job level were set to none

Fix

  • Adding contents write permission which is needed to create a release tag.

@jonathanedey jonathanedey added release:publish Publish a release candidate release:tweet Post the release notification to Twitter labels Jan 23, 2024
@jonathanedey jonathanedey merged commit b992604 into master Jan 23, 2024
13 checks passed
@lahirumaramba lahirumaramba deleted the je-release-640 branch January 23, 2024 22:12
jonathanedey added a commit that referenced this pull request Feb 13, 2024
@jonathanedey
[chore] Release 6.4.0 Take 3 (#763)
beaf884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees
No one assigned
Labels
release:publish Publish a release candidate release:tweet Post the release notification to Twitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathanedey @lahirumaramba