Changed the delete_app() function to accept an App instance #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwngr
suggested changes
Mar 28, 2017
| with _apps_lock: | ||
| if name in _apps: | ||
| del _apps[name] | ||
| if _apps.get(app.name) is app: |
There was a problem hiding this comment.
It can be. I'm just being a bit extra cautious here, so that somebody doesn't create an App instance by calling the constructor directly, and then pass it here. Basically something like:
app1 = initialize_app(cred, name='foo')
app2 = App(name='foo', cred)
delete_app(app2)
Without the above check, this code will delete app1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.