Skip to content

Reading project_id directly from google creds #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2017
Merged

Reading project_id directly from google creds #98

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b7bb0a
Reading project_id directly from google creds
hiranya911 Dec 1, 2017
613ccc1
Merge branch 'master' into hkj-auth-cleanup
hiranya911 Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions firebase_admin/credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ def __init__(self, cert):
if json_data.get('type') != self._CREDENTIAL_TYPE:
raise ValueError('Invalid service account certificate. Certificate must contain a '
'"type" field set to "{0}".'.format(self._CREDENTIAL_TYPE))
self._project_id = json_data.get('project_id')
try:
self._g_credential = service_account.Credentials.from_service_account_info(
json_data, scopes=_scopes)
Expand All @@ -98,7 +97,7 @@ def __init__(self, cert):

@property
def project_id(self):
return self._project_id
return self._g_credential.project_id

@property
def signer(self):
Expand Down