Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionToken Persistence #5941

Merged
merged 18 commits into from
Jun 18, 2024
Merged

sessionToken Persistence #5941

merged 18 commits into from
Jun 18, 2024

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented May 8, 2024 •
edited

Future builds upon persiting a sessionToken.

This PR prepares by implementing the persistence layer.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 8, 2024 •
edited

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from ? (1aebbd3) to 44.81% (be541f1) by ?.

    339 individual files with coverage change

    FilenameBase (1aebbd3)Merge (be541f1)Diff
    AbstractStream.java?34.81%?
    ActivityScope.java?0.00%?
    AggregateField.java?31.03%?
    AggregateQuery.java?22.73%?
    AggregateQuerySnapshot.java?59.52%?
    AggregateSource.java?0.00%?
    AggregationResult.java?0.00%?
    AggregationResultOrBuilder.java?0.00%?
    AggregationResultProto.java?0.00%?
    AndroidConnectivityMonitor.java?46.91%?
    ApiUtil.java?12.50%?
    ArrayContainsAnyFilter.java?100.00%?
    ArrayContainsFilter.java?100.00%?
    ArrayTransformOperation.java?86.49%?
    ArrayValue.java?48.60%?
    ArrayValueOrBuilder.java?0.00%?
    Assert.java?60.00%?
    AsyncEventListener.java?0.00%?
    AsyncQueue.java?70.65%?
    AutoValue_FieldIndex.java?58.33%?
    AutoValue_FieldIndex_IndexOffset.java?55.17%?
    AutoValue_FieldIndex_IndexState.java?59.09%?
    AutoValue_FieldIndex_Segment.java?54.17%?
    AutoValue_IndexEntry.java?34.21%?
    AutoValue_Overlay.java?54.55%?
    AutoValue_TestingHooks_ExistenceFilterBloomFilterInfo.java?20.00%?
    AutoValue_TestingHooks_ExistenceFilterMismatchInfo.java?23.08%?
    BackgroundQueue.java?81.25%?
    BasePath.java?86.54%?
    BatchGetDocumentsRequest.java?0.00%?
    BatchGetDocumentsRequestOrBuilder.java?0.00%?
    BatchGetDocumentsResponse.java?0.00%?
    BatchGetDocumentsResponseOrBuilder.java?0.00%?
    BeginTransactionRequest.java?0.00%?
    BeginTransactionRequestOrBuilder.java?0.00%?
    BeginTransactionResponse.java?0.00%?
    BeginTransactionResponseOrBuilder.java?0.00%?
    BitSequence.java?43.48%?
    BitSequenceOrBuilder.java?0.00%?
    Blob.java?76.92%?
    BloomFilter.java?87.72%?
    BloomFilterOrBuilder.java?0.00%?
    BloomFilterProto.java?0.00%?
    Bound.java?39.29%?
    BundleCache.java?0.00%?
    BundleCallback.java?0.00%?
    BundledDocumentMetadata.java?0.00%?
    BundledDocumentMetadataOrBuilder.java?0.00%?
    BundleDocument.java?90.00%?
    BundledQuery.java?34.57%?
    BundledQueryOrBuilder.java?0.00%?
    BundleElement.java?0.00%?
    BundleElementOrBuilder.java?0.00%?
    BundleLoader.java?100.00%?
    BundleMetadata.java?0.00%?
    BundleMetadataOrBuilder.java?0.00%?
    BundleProto.java?0.00%?
    BundleReader.java?95.29%?
    BundleSerializer.java?89.52%?
    ByteBufferInputStream.java?83.33%?
    CollectionReference.java?13.64%?
    CommitRequest.java?0.00%?
    CommitRequestOrBuilder.java?0.00%?
    CommitResponse.java?0.00%?
    CommitResponseOrBuilder.java?0.00%?
    CommonProto.java?0.00%?
    ComponentProvider.java?100.00%?
    CompositeFilter.java?90.91%?
    ConnectivityMonitor.java?0.00%?
    Consumer.java?0.00%?
    CreateDocumentRequest.java?0.00%?
    CreateDocumentRequestOrBuilder.java?0.00%?
    CredentialsProvider.java?100.00%?
    Cursor.java?35.29%?
    CursorOrBuilder.java?0.00%?
    CustomClassMapper.java?84.44%?
    DatabaseId.java?70.37%?
    DatabaseInfo.java?90.91%?
    Datastore.java?24.55%?
    DatastoreTestTrace.java?0.00%?
    DeleteDocumentRequest.java?0.00%?
    DeleteDocumentRequestOrBuilder.java?0.00%?
    DeleteMutation.java?95.24%?
    DirectionalIndexByteEncoder.java?100.00%?
    Document.java?100.00%?
    DocumentChange.java?67.61%?
    DocumentChangeOrBuilder.java?0.00%?
    DocumentCollections.java?83.33%?
    DocumentDelete.java?34.62%?
    DocumentDeleteOrBuilder.java?0.00%?
    DocumentId.java?0.00%?
    DocumentKey.java?97.14%?
    DocumentMask.java?40.66%?
    DocumentMaskOrBuilder.java?0.00%?
    DocumentOrBuilder.java?0.00%?
    DocumentOverlayCache.java?0.00%?
    DocumentProto.java?0.00%?
    DocumentReference.java?12.50%?
    DocumentRemove.java?29.23%?
    DocumentRemoveOrBuilder.java?0.00%?
    DocumentSet.java?83.78%?
    DocumentSnapshot.java?53.13%?
    DocumentTransform.java?29.31%?
    DocumentTransformOrBuilder.java?0.00%?
    DocumentViewChange.java?90.91%?
    DocumentViewChangeSet.java?87.88%?
    Emitters.kt?0.00%?
    EncodedPath.java?93.22%?
    EventListener.java?0.00%?
    EventManager.java?92.31%?
    Exclude.java?0.00%?
    Executors.java?100.00%?
    ExistenceFilter.java?90.00%?
    ExistenceFilterOrBuilder.java?0.00%?
    ExponentialBackoff.java?30.43%?
    FieldFilter.java?94.20%?
    FieldIndex.java?98.18%?
    FieldMask.java?57.89%?
    FieldPath.java?93.10%?
    FieldTransform.java?64.71%?
    FieldValue.java?82.14%?
    FileUtil.java?0.00%?
    Filter.java?78.57%?
    FirebaseAppCheckTokenProvider.java?93.75%?
    FirebaseAuthCredentialsProvider.java?100.00%?
    FirebaseClientGrpcMetadataProvider.java?44.00%?
    FirebaseFirestore.java?39.68%?
    FirebaseFirestoreException.java?83.72%?
    FirebaseFirestoreSettings.java?77.53%?
    Firestore.kt?42.31%?
    FirestoreCallCredentials.java?18.60%?
    FirestoreChannel.java?18.10%?
    FirestoreClient.java?34.67%?
    FirestoreGrpc.java?3.13%?
    FirestoreIndexValueWriter.java?77.11%?
    FirestoreMultiDbComponent.java?100.00%?
    FirestoreProto.java?0.00%?
    FirestoreRegistrar.java?100.00%?
    Function.java?0.00%?
    GeoPoint.java?91.67%?
    GetDocumentRequest.java?0.00%?
    GetDocumentRequestOrBuilder.java?0.00%?
    GlobalsCache.java?0.00%?
    GrpcCallProvider.java?69.41%?
    GrpcMetadataProvider.java?0.00%?
    IgnoreExtraProperties.java?0.00%?
    IncomingStreamObserver.java?0.00%?
    Index.java?30.02%?
    IndexBackfiller.java?100.00%?
    IndexByteEncoder.java?88.57%?
    IndexEntry.java?100.00%?
    IndexManager.java?100.00%?
    IndexOrBuilder.java?0.00%?
    IndexProto.java?0.00%?
    InFilter.java?100.00%?
    IntMath.java?41.67%?
    KeyFieldFilter.java?66.67%?
    KeyFieldInFilter.java?0.00%?
    KeyFieldNotInFilter.java?0.00%?
    LimboDocumentChange.java?70.59%?
    ListCollectionIdsRequest.java?0.00%?
    ListCollectionIdsRequestOrBuilder.java?0.00%?
    ListCollectionIdsResponse.java?0.00%?
    ListCollectionIdsResponseOrBuilder.java?0.00%?
    ListDocumentsRequest.java?0.00%?
    ListDocumentsRequestOrBuilder.java?0.00%?
    ListDocumentsResponse.java?0.00%?
    ListDocumentsResponseOrBuilder.java?0.00%?
    Listener.java?0.00%?
    ListenerRegistration.java?0.00%?
    ListenerRegistrationImpl.java?0.00%?
    ListenRequest.java?10.66%?
    ListenRequestOrBuilder.java?0.00%?
    ListenResponse.java?32.64%?
    ListenResponseOrBuilder.java?0.00%?
    ListenSequence.java?100.00%?
    ListenSource.java?100.00%?
    LoadBundleTask.java?25.26%?
    LoadBundleTaskProgress.java?60.47%?
    LocalCacheSettings.java?0.00%?
    LocalDocumentsResult.java?100.00%?
    LocalDocumentsView.java?100.00%?
    LocalSerializer.java?97.35%?
    LocalStore.java?99.10%?
    LocalViewChanges.java?100.00%?
    Logger.java?91.67%?
    LogicUtils.java?96.67%?
    LruDelegate.java?0.00%?
    LruGarbageCollector.java?93.64%?
    MapValue.java?53.00%?
    MapValueOrBuilder.java?0.00%?
    MemoryBundleCache.java?100.00%?
    MemoryCacheSettings.java?87.50%?
    MemoryComponentProvider.java?82.93%?
    MemoryDocumentOverlayCache.java?100.00%?
    MemoryEagerGcSettings.java?71.43%?
    MemoryEagerReferenceDelegate.java?100.00%?
    MemoryGarbageCollectorSettings.java?0.00%?
    MemoryGlobalsCache.java?100.00%?
    MemoryIndexManager.java?64.52%?
    MemoryLruGcSettings.java?62.50%?
    MemoryLruReferenceDelegate.java?96.00%?
    MemoryMutationQueue.java?100.00%?
    MemoryOverlayMigrationManager.java?100.00%?
    MemoryPersistence.java?100.00%?
    MemoryRemoteDocumentCache.java?98.31%?
    MemoryTargetCache.java?100.00%?
    MetadataChanges.java?100.00%?
    MutableDocument.java?100.00%?
    Mutation.java?100.00%?
    MutationBatch.java?89.23%?
    MutationBatchResult.java?100.00%?
    MutationQueue.java?0.00%?
    MutationResult.java?100.00%?
    NamedQuery.java?0.00%?
    NamedQueryOrBuilder.java?0.00%?
    NotInFilter.java?85.71%?
    NumberComparisonHelper.java?100.00%?
    NumericIncrementTransformOperation.java?87.50%?
    ObjectValue.java?99.06%?
    OnlineState.java?100.00%?
    OnlineStateTracker.java?98.11%?
    OnProgressListener.java?0.00%?
    OrderBy.java?96.55%?
    OrderedCodeWriter.java?68.52%?
    Overlay.java?100.00%?
    OverlayedDocument.java?100.00%?
    OverlayMigrationManager.java?0.00%?
    PatchMutation.java?100.00%?
    Persistence.java?100.00%?
    PersistentCacheIndexManager.java?0.00%?
    PersistentCacheSettings.java?62.50%?
    Precondition.java?37.82%?
    PreconditionOrBuilder.java?0.00%?
    Preconditions.java?57.89%?
    PropertyName.java?0.00%?
    Query.java?4.15%?
    QueryContext.java?100.00%?
    QueryDocumentSnapshot.java?64.71%?
    QueryEngine.java?99.00%?
    QueryListener.java?98.68%?
    QueryProto.java?0.00%?
    QueryPurpose.java?100.00%?
    QueryResult.java?100.00%?
    QuerySnapshot.java?76.36%?
    QueryView.java?100.00%?
    ReferenceDelegate.java?0.00%?
    ReferenceSet.java?92.45%?
    RemoteDocumentCache.java?0.00%?
    RemoteEvent.java?92.31%?
    RemoteSerializer.java?79.83%?
    RemoteStore.java?88.80%?
    ResourcePath.java?94.74%?
    RollbackRequest.java?0.00%?
    RollbackRequestOrBuilder.java?0.00%?
    RunAggregationQueryRequest.java?0.00%?
    RunAggregationQueryRequestOrBuilder.java?0.00%?
    RunAggregationQueryResponse.java?0.00%?
    RunAggregationQueryResponseOrBuilder.java?0.00%?
    RunQueryRequest.java?0.00%?
    RunQueryRequestOrBuilder.java?0.00%?
    RunQueryResponse.java?0.00%?
    RunQueryResponseOrBuilder.java?0.00%?
    SafeCollector.common.kt?0.00%?
    Scheduler.java?0.00%?
    ServerTimestamp.java?0.00%?
    ServerTimestampOperation.java?100.00%?
    ServerTimestamps.java?96.00%?
    SetMutation.java?97.22%?
    SetOptions.java?0.00%?
    SnapshotListenOptions.java?0.00%?
    SnapshotMetadata.java?68.75%?
    SnapshotVersion.java?87.50%?
    Source.java?0.00%?
    SQLiteBundleCache.java?90.00%?
    SQLiteComponentProvider.java?100.00%?
    SQLiteDocumentOverlayCache.java?97.85%?
    SQLiteGlobalsCache.java?100.00%?
    SQLiteIndexManager.java?99.51%?
    SQLiteLruReferenceDelegate.java?98.75%?
    SQLiteMutationQueue.java?82.76%?
    SQLiteOverlayMigrationManager.java?90.48%?
    SQLitePersistence.java?86.41%?
    SQLiteRemoteDocumentCache.java?98.31%?
    SQLiteSchema.java?96.70%?
    SQLiteTargetCache.java?98.47%?
    Stream.java?100.00%?
    StructuredAggregationQuery.java?0.00%?
    StructuredAggregationQueryOrBuilder.java?0.00%?
    StructuredQuery.java?32.54%?
    StructuredQueryOrBuilder.java?0.00%?
    Supplier.java?0.00%?
    SyncEngine.java?89.22%?
    Target.java?96.26%?
    TargetCache.java?0.00%?
    TargetChange.java?80.00%?
    TargetChangeOrBuilder.java?0.00%?
    TargetData.java?77.78%?
    TargetIdGenerator.java?100.00%?
    TargetIndexMatcher.java?96.81%?
    TargetOrBuilder.java?0.00%?
    TargetState.java?97.78%?
    TestingHooks.java?66.67%?
    ThrottledForwardingExecutor.java?100.00%?
    ThrowOnExtraProperties.java?0.00%?
    Token.java?0.00%?
    Transaction.java?0.00%?
    TransactionOptions.java?0.00%?
    TransactionOptionsOrBuilder.java?0.00%?
    TransactionRunner.java?0.00%?
    TransformOperation.java?0.00%?
    UpdateDocumentRequest.java?0.00%?
    UpdateDocumentRequestOrBuilder.java?0.00%?
    User.java?78.57%?
    UserData.java?66.00%?
    UserDataReader.java?70.48%?
    UserDataWriter.java?51.02%?
    Util.java?67.63%?
    Value.java?41.22%?
    ValueOrBuilder.java?0.00%?
    Values.java?95.65%?
    VerifyMutation.java?46.15%?
    View.java?96.82%?
    ViewChange.java?100.00%?
    ViewSnapshot.java?89.23%?
    WatchChange.java?70.51%?
    WatchChangeAggregator.java?98.64%?
    WatchStream.java?19.23%?
    Write.java?36.11%?
    WriteBatch.java?0.00%?
    WriteOrBuilder.java?0.00%?
    WriteProto.java?0.00%?
    WriteRequest.java?10.41%?
    WriteRequestOrBuilder.java?0.00%?
    WriteResponse.java?11.70%?
    WriteResponseOrBuilder.java?0.00%?
    WriteResult.java?0.00%?
    WriteResultOrBuilder.java?0.00%?
    WriteStream.java?31.82%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GtVaKYFAl8.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited

Unit Test Results

   182 files     182 suites   4m 39s ⏱️
1 229 tests 1 213 ✔️ 16 💤 0 ❌
2 482 runs  2 450 ✔️ 32 💤 0 ❌

Results for commit 5e3dace.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 8, 2024 •
edited

Size Report 1

Affected Products

  • base

    TypeBase (1aebbd3)Merge (be541f1)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-firestore

    TypeBase (1aebbd3)Merge (be541f1)Diff
    aar?1.43 MB? (?)
    apk (aggressive)?554 kB? (?)
    apk (release)?11.1 MB? (?)

  • protolite-well-known-types

    TypeBase (1aebbd3)Merge (be541f1)Diff
    aar?1.01 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.68 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sWEUeh8MVh.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 8, 2024 •
edited

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentilee3c052a270e250DiffSignificant (?)
    p10310 ±14 μs315 ±23 μs+5.01 μs (+1.6%)NO
    p25321 ±19 μs325 ±23 μs+4.00 μs (+1.2%)NO
    p50339 ±27 μs348 ±31 μs+9.52 μs (+2.8%)NO
    p75388 ±75 μs405 ±71 μs+17.5 μs (+4.5%)NO
    p90445 ±111 μs492 ±82 μs+47.1 μs (+10.6%)NO

    20 test runs in comparison
    CommitTest Runs
    e3c052a
    • 2024-05-22_18:51:00.476928_rGSz
    • 2024-05-22_18:51:00.476973_JjDB
    • 2024-05-22_18:51:00.476983_bUok
    • 2024-05-22_18:51:00.476991_yZVU
    • 2024-05-22_18:51:00.476998_LFhH
    • 2024-05-22_18:51:00.477012_tYJz
    • 2024-05-22_18:51:00.477020_zWQE
    • 2024-05-22_18:51:00.477028_NaDl
    • 2024-05-22_18:51:00.477036_viap
    • 2024-05-22_18:51:00.477043_JFDa
    270e250
    • 2024-05-22_20:24:22.112263_nwQy
    • 2024-05-22_20:24:22.112305_OhSy
    • 2024-05-22_20:24:22.112317_ZGYI
    • 2024-05-22_20:24:22.112326_DFyV
    • 2024-05-22_20:24:22.112331_WHci
    • 2024-05-22_20:24:22.112336_ZSkW
    • 2024-05-22_20:24:22.112341_Yqam
    • 2024-05-22_20:24:22.112345_xtTS
    • 2024-05-22_20:24:22.112349_BfGy
    • 2024-05-22_20:24:22.112353_utEG
    redfin-30
    Percentilee3c052a270e250DiffSignificant (?)
    p10626 ±31 μs618 ±19 μs-7.82 μs (-1.2%)NO
    p25649 ±41 μs638 ±23 μs-11.6 μs (-1.8%)NO
    p50683 ±51 μs668 ±29 μs-15.6 μs (-2.3%)NO
    p75725 ±62 μs704 ±38 μs-20.2 μs (-2.8%)NO
    p90779 ±75 μs749 ±53 μs-30.7 μs (-3.9%)NO

    20 test runs in comparison
    CommitTest Runs
    e3c052a
    • 2024-05-22_18:51:00.476928_rGSz
    • 2024-05-22_18:51:00.476973_JjDB
    • 2024-05-22_18:51:00.476983_bUok
    • 2024-05-22_18:51:00.476991_yZVU
    • 2024-05-22_18:51:00.476998_LFhH
    • 2024-05-22_18:51:00.477012_tYJz
    • 2024-05-22_18:51:00.477020_zWQE
    • 2024-05-22_18:51:00.477028_NaDl
    • 2024-05-22_18:51:00.477036_viap
    • 2024-05-22_18:51:00.477043_JFDa
    270e250
    • 2024-05-22_20:24:22.112263_nwQy
    • 2024-05-22_20:24:22.112305_OhSy
    • 2024-05-22_20:24:22.112317_ZGYI
    • 2024-05-22_20:24:22.112326_DFyV
    • 2024-05-22_20:24:22.112331_WHci
    • 2024-05-22_20:24:22.112336_ZSkW
    • 2024-05-22_20:24:22.112341_Yqam
    • 2024-05-22_20:24:22.112345_xtTS
    • 2024-05-22_20:24:22.112349_BfGy
    • 2024-05-22_20:24:22.112353_utEG

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilee3c052a270e250DiffSignificant (?)
    p10201 ±4 ms207 ±6 ms+6.59 ms (+3.3%)NO
    p25206 ±4 ms213 ±7 ms+6.68 ms (+3.2%)NO
    p50213 ±5 ms220 ±8 ms+6.63 ms (+3.1%)NO
    p75221 ±5 ms228 ±8 ms+7.22 ms (+3.3%)NO
    p90230 ±5 ms243 ±17 ms+12.9 ms (+5.6%)NO

    20 test runs in comparison
    CommitTest Runs
    e3c052a
    • 2024-05-22_18:51:00.476928_rGSz
    • 2024-05-22_18:51:00.476973_JjDB
    • 2024-05-22_18:51:00.476983_bUok
    • 2024-05-22_18:51:00.476991_yZVU
    • 2024-05-22_18:51:00.476998_LFhH
    • 2024-05-22_18:51:00.477012_tYJz
    • 2024-05-22_18:51:00.477020_zWQE
    • 2024-05-22_18:51:00.477028_NaDl
    • 2024-05-22_18:51:00.477036_viap
    • 2024-05-22_18:51:00.477043_JFDa
    270e250
    • 2024-05-22_20:24:22.112263_nwQy
    • 2024-05-22_20:24:22.112305_OhSy
    • 2024-05-22_20:24:22.112317_ZGYI
    • 2024-05-22_20:24:22.112326_DFyV
    • 2024-05-22_20:24:22.112331_WHci
    • 2024-05-22_20:24:22.112336_ZSkW
    • 2024-05-22_20:24:22.112341_Yqam
    • 2024-05-22_20:24:22.112345_xtTS
    • 2024-05-22_20:24:22.112349_BfGy
    • 2024-05-22_20:24:22.112353_utEG
    redfin-30
    Percentilee3c052a270e250DiffSignificant (?)
    p10247 ±8 ms272 ±7 ms+25.5 ms (+10.3%)MAYBE
    p25255 ±11 ms281 ±11 ms+25.8 ms (+10.1%)NO
    p50263 ±12 ms290 ±13 ms+26.2 ms (+9.9%)NO
    p75274 ±11 ms300 ±14 ms+25.3 ms (+9.2%)NO
    p90288 ±9.6 ms312 ±12 ms+24.1 ms (+8.4%)NO

    20 test runs in comparison
    CommitTest Runs
    e3c052a
    • 2024-05-22_18:51:00.476928_rGSz
    • 2024-05-22_18:51:00.476973_JjDB
    • 2024-05-22_18:51:00.476983_bUok
    • 2024-05-22_18:51:00.476991_yZVU
    • 2024-05-22_18:51:00.476998_LFhH
    • 2024-05-22_18:51:00.477012_tYJz
    • 2024-05-22_18:51:00.477020_zWQE
    • 2024-05-22_18:51:00.477028_NaDl
    • 2024-05-22_18:51:00.477036_viap
    • 2024-05-22_18:51:00.477043_JFDa
    270e250
    • 2024-05-22_20:24:22.112263_nwQy
    • 2024-05-22_20:24:22.112305_OhSy
    • 2024-05-22_20:24:22.112317_ZGYI
    • 2024-05-22_20:24:22.112326_DFyV
    • 2024-05-22_20:24:22.112331_WHci
    • 2024-05-22_20:24:22.112336_ZSkW
    • 2024-05-22_20:24:22.112341_Yqam
    • 2024-05-22_20:24:22.112345_xtTS
    • 2024-05-22_20:24:22.112349_BfGy
    • 2024-05-22_20:24:22.112353_utEG

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AYflD4m5H5/index.html

@tom-andersen tom-andersen marked this pull request as ready for review May 14, 2024 15:15
wu-hui
wu-hui reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test to SQLiteSchemaTest.java?

firebase-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteSchema.java Outdated Show resolved Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/local/GlobalsCache.java Outdated Show resolved Hide resolved
@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui May 24, 2024
@tom-andersen tom-andersen requested a review from wu-hui June 14, 2024 13:17
wu-hui
wu-hui requested changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits. Please also add a test to SQLiteSchemaTest.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/GlobalsCache.java Outdated Show resolved Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteGlobalsCache.java Show resolved Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteGlobalsCache.java Outdated Show resolved Hide resolved
@tom-andersen tom-andersen requested a review from wu-hui June 17, 2024 21:13
@tom-andersen tom-andersen changed the title dbToken Persistence sessionToken Persistence Jun 17, 2024
@tom-andersen tom-andersen merged commit 0a54f10 into main Jun 18, 2024
21 of 24 checks passed
@tom-andersen tom-andersen deleted the tomandersen/dbToken branch June 18, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@tom-andersen tom-andersen

@wu-hui wu-hui

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tom-andersen @google-oss-bot @wu-hui