Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust FDL deprecation wording. #6002

Merged
merged 2 commits into from
May 29, 2024
Merged

Adjust FDL deprecation wording. #6002

merged 2 commits into from
May 29, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented May 29, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 29, 2024 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@rlazo rlazo requested review from VinayGuthal and daymxn May 29, 2024 09:28
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 29, 2024 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (72cf2ea) and merge commit (8eb0c87).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Qpdez7qowJ.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 29, 2024 •
edited
Loading

Unit Test Results

  22 files   -      914    22 suites   - 914   42s ⏱️ - 32m 57s
115 tests  -   5 090  114 ✔️  -   5 070  1 💤  - 20  0 ❌ ±0 
252 runs   - 10 219  250 ✔️  - 10 179  2 💤  - 40  0 ❌ ±0 

Results for commit 1ee194e. ± Comparison against base commit 72cf2ea.

♻️ This comment has been updated with latest results.

@rlazo
Copy link
Collaborator Author

rlazo commented May 29, 2024

test

@rlazo rlazo merged commit a5c4031 into master May 29, 2024
21 of 25 checks passed
@rlazo rlazo deleted the rl.fdl.rewording.deprecation branch May 29, 2024 14:53
rlazo added a commit that referenced this pull request May 29, 2024
@rlazo
Adjust FDL deprecation wording. (#6002)
9b72e3a
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VinayGuthal VinayGuthal VinayGuthal approved these changes

@daymxn daymxn Awaiting requested review from daymxn

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @VinayGuthal