Skip to content

Remove vcpkg from testapp builder #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Remove vcpkg from testapp builder #1080

merged 2 commits into from
Sep 21, 2022

Conversation

a-maurice
Copy link
Contributor

@a-maurice a-maurice commented Sep 21, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

vcpkg has been having errors finding the toolchain files, and should not be necessary for the build, so remove it from the testapp builder logic.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

https://github.com/firebase/firebase-cpp-sdk/actions/runs/3099919285


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Sep 21, 2022
@a-maurice a-maurice merged commit 5e79c61 into main Sep 21, 2022
@a-maurice a-maurice deleted the am-vcpkg_problems branch September 21, 2022 20:01
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Sep 21, 2022
@github-actions
Copy link

github-actions bot commented Sep 21, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit 5e79c61
Last updated: Wed Sep 21 16:22 PDT 2022
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Sep 21, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 21, 2022
@firebase firebase locked and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants