Skip to content

Fix lint error by removing brace initialization syntax from strings. #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 30, 2022
Merged

Fix lint error by removing brace initialization syntax from strings. #1095

merged 4 commits into from
Sep 30, 2022

Conversation

jonsimantov
Copy link
Contributor

Description

The linter does not like the std::string{} brace initialization syntax and spits out errors. This fixes those errors.

Testing

PR checks run to ensure the build has not broken.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov mentioned this pull request Sep 29, 2022
Merged
3 tasks
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Sep 29, 2022
AlmostMatt
AlmostMatt reviewed Sep 30, 2022
View reviewed changes
Copy link
Contributor

@AlmostMatt AlmostMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like file format check failed because this line was accidentally unindented

AlmostMatt
AlmostMatt approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@AlmostMatt AlmostMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I thought the curly brace initialization was weird but didn't know why it was done and so I left it alone.

@jonsimantov jonsimantov enabled auto-merge (squash) September 30, 2022 17:06
@jonsimantov jonsimantov merged commit c621a5d into main Sep 30, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Sep 30, 2022
@github-actions
Copy link

github-actions bot commented Sep 30, 2022 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit c621a5d
Last updated: Fri Sep 30 13:46 PDT 2022
View integration test log & download artifacts

Failures Configs
functions [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseFunctionsTest.TestFunctionWithData

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Sep 30, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 30, 2022
@firebase firebase locked and limited conversation to collaborators Oct 31, 2022
@jonsimantov jonsimantov deleted the fix_verify_assertion_request_lint_error branch November 3, 2022 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlmostMatt AlmostMatt AlmostMatt approved these changes

Assignees

@AlmostMatt AlmostMatt

Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @AlmostMatt