Skip to content

CMakeLists.txt: Add FIREBASE_FLATC_CMAKE_COMMAND #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 19, 2022
Merged

CMakeLists.txt: Add FIREBASE_FLATC_CMAKE_COMMAND #1103

merged 8 commits into from
Oct 19, 2022

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Oct 7, 2022 •
edited
Loading

This PR adds a new cmake cache variable, FIREBASE_FLATC_CMAKE_COMMAND, which can be used to specify the path of the cmake executable to use when compiling flatc. If not specified, it uses cmake from the PATH. This works just fine most of the time; however, some build environments (such as building from CLion) do not have cmake in the PATH. In these cases, a workaround is to specify the absolute path to the cmake executable using this new cache variable.

@dconeybe dconeybe self-assigned this Oct 7, 2022
@dconeybe dconeybe added the skip-release-notes Skip release notes check label Oct 7, 2022
@dconeybe dconeybe changed the title CMakeLists.txt: use ${CMAKE_COMMAND} instead of hardcoding cmake when building flatc CMakeLists.txt: Add FIREBASE_FLATC_CMAKE_COMMAND Oct 17, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Oct 17, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 17, 2022
@github-actions
Copy link

github-actions bot commented Oct 17, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @dconeybe on commit 88ad013
Last updated: Wed Oct 19 00:56 PDT 2022
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [1/3 os: ubuntu] [1/2 android_device: emulator_target]
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdStress
storage [TEST] [ERROR] [iOS] [macos] [All 2 ios_device]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 17, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 17, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Oct 17, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 17, 2022
@dconeybe dconeybe removed the tests: failed This PR's integration tests failed. label Oct 17, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 17, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 17, 2022
@dconeybe dconeybe added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Oct 17, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 17, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 17, 2022
@dconeybe dconeybe added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Oct 17, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 17, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 18, 2022
cynthiajoan
cynthiajoan previously approved these changes Oct 19, 2022
View reviewed changes
@dconeybe dconeybe removed the tests: failed This PR's integration tests failed. label Oct 19, 2022
@github-actions github-actions bot dismissed cynthiajoan’s stale review October 19, 2022 03:22

🍞 Dismissed stale approval on external PR.

@dconeybe dconeybe enabled auto-merge (squash) October 19, 2022 03:27
@dconeybe dconeybe merged commit 88ad013 into main Oct 19, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Oct 19, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 19, 2022
@dconeybe dconeybe deleted the dconeybe/FlatcCmakePathFix branch October 19, 2022 13:01
@firebase firebase locked and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees

@dconeybe dconeybe

Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @cynthiajoan