Firestore build and testing improvements and documentation #1113

wu-hui · 2022-10-17T19:52:10Z

No description provided.

…vements'

github-actions · 2022-10-18T00:12:33Z

❌ Integration test FAILED

Requested by @wu-hui on commit 0cac295
Last updated: Thu Dec 15 16:41 PST 2022
View integration test log & download artifacts

Failures	Configs
firestore	[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target] (1 failed tests) SourceTest.GetCollectionWhileOfflineWithDefaultGetOptions
gma	[TEST] [ERROR] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target] [TEST] [FAILURE] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target] (1 failed tests) FirebaseGmaTest.TestRewardedAdStress

Add flaky tests to go/fpl-cpp-flake-tracker

tom-andersen

This looks super helpful.

I noticed a few problems with wording and additions I would like to see.

tom-andersen · 2022-11-01T17:24:02Z

firestore/CONTRIBUTING.md

+
+It is easier to work this Firestore CPP SDK by keeping a high level archetecture in mind:
+
+![architecture.png](architecture.png)


I am not sure where this diagram came from, but instinctively the arrows seem to point in the wrong direction. I looked up UML diagrams, and how IntelliJ does a Dependency Diagrams (also based on UML I think), and they all seem to point towards the root of dependency.

The first question that popped into my mind when I saw this diagram was: Why does Core SDK have knowledge of Swift? Shouldn't Swift just be an agnostic wrapper around Core SDK? Then I realized that my understanding of arrows (which is consistent with UML) is completely backwards to what the diagram uses.

Addressed. I am never a fan of UML, but I guess there is value to follow known conventions.

tom-andersen · 2022-11-01T17:31:31Z

firestore/CONTRIBUTING.md

+
+## IDE Integration
+
+Open up the repo root directory from `CLion` should load all symbols for the SDK itsel should 


There are some repeated words:

should load all symbols for the SDK itsel

tom-andersen · 2022-11-01T17:32:06Z

firestore/CONTRIBUTING.md

+## IDE Integration
+
+Open up the repo root directory from `CLion` should load all symbols for the SDK itsel should 
+load all symbols for the SDK itself. Once loaded, you can right load on 


I think right load should be right click ? What option from drop down menu should I choose?

tom-andersen · 2022-11-01T17:46:49Z

firestore/CONTRIBUTING.md

+
+# Android building and testing
+
+Once Android NDK is installed and added to `local.properties`, and `google-services.json`,


Where can I find more instruction on installing Android NDK? If I recall, there is a specific version that must be used.

local.properties should be the same as you use for Android. Or is there anything in particular?

wu-hui

@tom-andersen Please take another look.

🍞 Dismissed stale approval on external PR.

wu-hui and others added 15 commits October 6, 2022 15:27

Initial checkin

f53c306

Format

87a7da1

Lint

f9d5f37

Merge branch 'main' into wuandy/DesktopImprovements

3084b41

Android documentation and fix

9a56e08

Add IDE integration.

d35bab3

Android documentation and fix

91165b9

Merge remote-tracking branch 'refs/remotes/origin/wuandy/AndroidImpro…

28810aa

…vements'

fix gitignore

1dfe8a1

Fix settings.gradle

932ea10

Merge branch 'wuandy/FixSettingsGradle'

203e403

Add empty lines

a75adb0

Add ios support

3737a4f

Fix build_testapp failure

808651e

Merge branch 'main' into wuandy/IOSImprovements

1e5bc80

wu-hui added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels Oct 18, 2022

github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 18, 2022

github-actions bot added the tests: failed This PR's integration tests failed. label Oct 18, 2022

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 18, 2022

Script

5570ee1

wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Oct 18, 2022

github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 18, 2022

wu-hui requested a review from tom-andersen October 18, 2022 14:49

wu-hui assigned tom-andersen Oct 18, 2022

wu-hui changed the title ~~Wuandy/ios improvements~~ Firestore build and testing improvements and documentation Oct 18, 2022

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 18, 2022

wu-hui requested a review from cherylEnkidu October 25, 2022 17:21

wu-hui assigned cherylEnkidu Oct 25, 2022

tom-andersen reviewed Nov 1, 2022

View reviewed changes

Address feedback

77e7c0e

wu-hui commented Dec 12, 2022

View reviewed changes

wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Dec 12, 2022

github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 12, 2022

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 12, 2022

tom-andersen previously approved these changes Dec 14, 2022

View reviewed changes

Merge branch 'main' into wuandy/IOSImprovements

ee404cd

wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Dec 15, 2022

github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 15, 2022

wu-hui removed the tests: failed This PR's integration tests failed. label Dec 15, 2022

github-actions bot added the tests: failed This PR's integration tests failed. label Dec 15, 2022

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 15, 2022

tom-andersen approved these changes Dec 15, 2022

View reviewed changes

wu-hui removed the tests: failed This PR's integration tests failed. label Dec 15, 2022

wu-hui merged commit 0cac295 into main Dec 15, 2022

github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Dec 15, 2022

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 16, 2022

firebase locked and limited conversation to collaborators Jan 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Firestore build and testing improvements and documentation #1113

Firestore build and testing improvements and documentation #1113

Uh oh!

wu-hui commented Oct 17, 2022

Uh oh!

github-actions bot commented Oct 18, 2022 •

edited

Loading

Uh oh!

tom-andersen left a comment

Uh oh!

tom-andersen Nov 1, 2022

Uh oh!

wu-hui Dec 12, 2022

Uh oh!

tom-andersen Nov 1, 2022

Uh oh!

wu-hui Dec 12, 2022

Uh oh!

tom-andersen Nov 1, 2022

Uh oh!

wu-hui Dec 12, 2022

Uh oh!

tom-andersen Nov 1, 2022

Uh oh!

wu-hui Dec 12, 2022

Uh oh!

wu-hui left a comment

Uh oh!

Uh oh!


		It is easier to work this Firestore CPP SDK by keeping a high level archetecture in mind:

		![architecture.png](architecture.png)


		## IDE Integration

		Open up the repo root directory from `CLion` should load all symbols for the SDK itsel should


		# Android building and testing

		Once Android NDK is installed and added to `local.properties`, and `google-services.json`,

Firestore build and testing improvements and documentation #1113

Firestore build and testing improvements and documentation #1113

Uh oh!

Conversation

wu-hui commented Oct 17, 2022

Uh oh!

github-actions bot commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Integration test FAILED

Uh oh!

tom-andersen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wu-hui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 18, 2022 •

edited

Loading