Skip to content

Update gitignore for integration test files #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Add files that are generated when building the integration tests to the gitignore file


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Oct 20, 2022
@a-maurice a-maurice requested a review from AlmostMatt October 20, 2022 22:03
@a-maurice a-maurice marked this pull request as ready for review October 20, 2022 22:03
Copy link
Contributor

@AlmostMatt AlmostMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok, but I also kind of wish that these autogenerated source files and folders were more clearly marked as such. For example, if they all ended up in a subdirectory called integration_test_build

@a-maurice a-maurice merged commit 09ac17f into main Oct 21, 2022
@a-maurice a-maurice deleted the am-test_ignores branch October 21, 2022 23:26
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Oct 21, 2022
@github-actions
Copy link

github-actions bot commented Oct 21, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit 09ac17f
Last updated: Fri Oct 21 19:35 PDT 2022
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: android_target]
gma [TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdStress
storage [TEST] [ERROR] [iOS] [macos] [All 2 ios_device]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 22, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 22, 2022
@firebase firebase locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants