tvOS Reference Docs Changes #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
approved these changes
Dec 22, 2022
auth/src/include/firebase/auth.h
Outdated
| @@ -174,7 +174,7 @@ class Auth { | |||
| void set_language_code(const char* language_code); | |||
|
|
|||
| /// Sets the user-facing language code to be the default app language. This | |||
| /// uses a languge associated with the phone's locale data. On desktop | |||
| /// uses a languge associated with the device's locale data. On desktop | |||
There was a problem hiding this comment.
While you're here, can you fix the typo "languge" => "language"?
| @@ -168,7 +168,7 @@ class Settings final { | |||
| * `set_dispatch_queue()`. | |||
| * | |||
| * @note This method is only available when `__OBJC__` is defined, such as | |||
| * when compiling for iOS. | |||
| * when compiling for iOS or tvOS | |||
| @@ -170,7 +170,7 @@ struct Notification { | |||
|
|
|||
| /// Indicates the key to the title string for localization. | |||
| /// | |||
| /// On iOS, this corresponds to "title-loc-key" in APNS payload. | |||
| /// On iOS amd tvOS, this corresponds to "title-loc-key" in APNS payload. | |||
jonsimantov
approved these changes
Dec 22, 2022
github-actions
bot
added
the
tests: in-progress
Integration test with FLAKINESS (succeeded after retry)Requested by @DellaBitta on commit b1a5444
Add flaky tests to go/fpl-cpp-flake-tracker |
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
chkuang-g
pushed a commit
that referenced
this pull request
Feb 24, 2023
Update the reference docs to refer to tvOS when discussing particular methods and classes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the reference docs to refer to tvOS when discussing particular methods and classes.
Testing
Packaging Build for docs push
Type of Change
Place an
xthe applicable box: