Skip to content

Add flaky retry to all network requests in Dynamic Links. #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2023
Merged

Add flaky retry to all network requests in Dynamic Links. #1202

merged 3 commits into from
Feb 2, 2023

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Sometimes the various GetShortLink* functions can fail with a network error, SSL error, etc. Add a retry to these operations in case they fail.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Run integration tests in this PR.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. skip-release-notes Skip release notes check labels Feb 2, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 179939a
Last updated: Thu Feb 2 14:43 PST 2023
View integration test log & download artifacts

Failures Configs
missing_log [BUILD] [ERROR] [tvOS] [macos]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Feb 2, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Feb 2, 2023
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Feb 2, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Feb 2, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 2, 2023
@jonsimantov jonsimantov enabled auto-merge (squash) February 2, 2023 20:45
@jonsimantov jonsimantov merged commit 179939a into main Feb 2, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Feb 2, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 2, 2023
chkuang-g pushed a commit that referenced this pull request Feb 24, 2023
@jonsimantov @chkuang-g
Add flaky retry to all network requests in Dynamic Links. (#1202)
59e2095 
* Add flaky retry to all network requests in Dynamic Links.

* Fix declaration.
@firebase firebase locked and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees

@DellaBitta DellaBitta

Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @DellaBitta