Skip to content

Check Google Play services version in Analytics test #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 9, 2023
Merged

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Mar 8, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Check the GMSCore version in the Analytics test - this allows us to simply skip the GetSessionId test on devices that don't support it.

Also force an event to be logged before getting the session ID, so we are sure to have an Analytics session.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

❌  Integration test FAILED

Requested by @jonsimantov on commit ae3d689
Last updated: Wed Mar 8 19:44 PST 2023
View integration test log & download artifacts

Failures Configs
admob [BUILD] [ERROR] [Android] [All 3 os]
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  NumericTransformsTest.DoubleIncrementWithExistingString
remote_config [BUILD] [ERROR] [Android] [All 3 os]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Mar 8, 2023
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Mar 8, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 8, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels Mar 8, 2023
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Mar 8, 2023
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Mar 8, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 8, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Mar 8, 2023
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Mar 8, 2023
@github-actions github-actions bot removed the tests: failed This PR's integration tests failed. label Mar 8, 2023
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Mar 8, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 8, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 8, 2023
@jonsimantov jonsimantov requested a review from a-maurice March 8, 2023 23:45
@jonsimantov jonsimantov marked this pull request as ready for review March 8, 2023 23:45
@jonsimantov jonsimantov enabled auto-merge (squash) March 9, 2023 00:35
@jonsimantov jonsimantov merged commit ae3d689 into main Mar 9, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Mar 9, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 9, 2023
@firebase firebase locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants