Skip to content

Update IOS FTL device model and os version #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Update IOS FTL device model and os version #1249

merged 2 commits into from
Mar 27, 2023

Conversation

cynthiajoan
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@cynthiajoan cynthiajoan requested a review from sunmou99 March 27, 2023 20:08
@cynthiajoan cynthiajoan added the skip-release-notes Skip release notes check label Mar 27, 2023
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure there is no new integration testing issues on these FTL devices before merge.

@cynthiajoan cynthiajoan merged commit b30ea36 into main Mar 27, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Mar 27, 2023
@github-actions
Copy link

github-actions bot commented Mar 27, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @cynthiajoan on commit b30ea36
Last updated: Mon Mar 27 18:21 PDT 2023
View integration test log & download artifacts

Failures Configs
database [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 28, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 28, 2023
@jonsimantov jonsimantov deleted the cj/misc branch April 18, 2023 00:17
@firebase firebase locked and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants