Skip to content

Patch leveldb for Windows UTF16 path support #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 12, 2023
Merged

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented May 10, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

This change adds a patch to leveldb to enable international path support. This will only affect RTDB builds when Firestore is not included (via the cmake -DFIREBASE_INCLUDE_FIRESTORE=off flag).

The Firestore-specific fix can be found in firebase/firebase-ios-sdk#11276, and will be included in the next iOS dependency update.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

The integration test was built and run against a branch of the iOS SDK with the fix, that specifically added international characters to the path. This was also manually run on a Windows machine to verify it works.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. skip-release-notes Skip release notes check labels May 10, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 10, 2023
@github-actions
Copy link

github-actions bot commented May 10, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit c5214c0
Last updated: Fri May 12 12:20 PDT 2023
View integration test log & download artifacts

Failures Configs
dynamic_links [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  QueryTest.TestListenUnlistenRelistenSequenceOfMirrorQueries
[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirestoreIntegrationTest.TimestampsAreTruncatedToMicroseconds
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 10, 2023
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label May 10, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 11, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 11, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels May 11, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 11, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels May 11, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 11, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 11, 2023
@jonsimantov jonsimantov changed the title Use Firestore SDK with leveldb patched for Windows UTF16 path support Patch leveldb for Windows UTF16 path support May 11, 2023
@jonsimantov jonsimantov removed the skip-release-notes Skip release notes check label May 11, 2023
@jonsimantov jonsimantov requested a review from a-maurice May 11, 2023 19:10
@jonsimantov jonsimantov marked this pull request as ready for review May 11, 2023 19:32
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 11, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels May 11, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 11, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 12, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 12, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 12, 2023
@jonsimantov jonsimantov merged commit c5214c0 into main May 12, 2023
@jonsimantov jonsimantov deleted the leveldb-windows-patch branch May 12, 2023 16:43
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels May 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 12, 2023
@firebase firebase locked and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants